Itamar Holder

Results 42 issues of Itamar Holder

**What this PR does / why we need it**: ## Problem ### Background This is a follow-up PR to https://github.com/kubevirt/kubevirt/pull/7599. The above PR solved a major bug in which the...

size/L
release-note
dco-signoff: yes

Currently, Kubevirt client set does not support watch calls, e.g.: ```go virtClient.Kubevirt(namespace).Watch(...) ``` Also, while some of our clients are auto-generated (e.g. [clone client](https://github.com/kubevirt/kubevirt/blob/v0.55.0/staging/src/kubevirt.io/client-go/generated/kubevirt/clientset/versioned/typed/clone/v1alpha1/virtualmachineclone.go)), the [Kubevirt client](https://github.com/kubevirt/kubevirt/blob/v0.55.0/staging/src/kubevirt.io/client-go/kubecli/kv.go) is not. Unless...

kind/enhancement

**Is this a BUG REPORT or FEATURE REQUEST?**: /kind enhancement **What happened**: Recently there were attempts to run Kubevirt on very large clusters (~100 nodes). During these attempts it a...

kind/enhancement
lifecycle/stale

**What this PR does / why we need it**: Currently, defining a custom hostname via cloud-init is a no-op. This PR aims to fix that. **Which issue(s) this PR fixes**...

size/L
release-note
do-not-merge/hold
lgtm
approved
dco-signoff: yes

**What this PR does / why we need it**: This PR adds support for cloning with a snapshot as source. In other words, after this PR we would be able...

size/XL
release-note
dco-signoff: yes

**What this PR does / why we need it**: Currently node-labeller does not watch any resource via informers. Instead, it wakes up every 3 minutes. This is a bug. Before...

size/L
release-note
do-not-merge/hold
lifecycle/stale
needs-rebase
do-not-merge/work-in-progress
dco-signoff: yes

Signed-off-by: Itamar Holder **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #(, fixes #, ...)` format, will close the issue(s) when...

size/M
do-not-merge/release-note-label-needed
do-not-merge/work-in-progress
dco-signoff: yes

Currently, there's no way to make a cgroup threaded via cgroup manager. Therefore, in Kubevirt, I had to implement it myself [1][2]. As I think this will be helpful to...

As can be seen in `go.mod`, we depend on `golang/mock` for mocking: https://github.com/kubevirt/kubevirt/blob/176d0529256dc8f7263e348b1743a89ec614cb51/go.mod#L20 However, as can be seen in https://github.com/golang/mock, this repository is now archived and no longer maintained. They...

good-first-issue

For more context, please look at the conversation here: https://github.com/kubernetes/kubernetes/pull/123557#discussion_r1525502183

lgtm
cncf-cla: yes
size/XS
sig/testing
sig/node
area/jobs
area/config