Itamar Holder
Itamar Holder
Thanks a lot @maiqueb! /lgtm
> Thank you for the review!! > > > 1. I think that having defaults in comments can be problematic. Since it's not enforced, there could easily be a case...
A general question: To track times, we generally use timestamps in the VMI's status. For example, `MigrationState` struct contains the timestamp of the beginning and end of the last migration....
> @iholder-redhat what do you think about something like @Barakmor1 suggestion? In essence, his suggestion seems valid in the sense that seconds aren't being used here, but a timestamp. This...
Hey @machadovilaca! > After discussing this solution with @sradco, we don't think using NewMetricWithTimestamp is the best approach. This shouldn't be surprising, the documentation says: `This is only useful in...
> After discussing this solution with @sradco, we don't think using NewMetricWithTimestamp is the best approach. > > For each VM state, we would only have one metric, timestamped to...
> @iholder-redhat @enp0s3 I had a meeting with Joao. For summery, We want the metrics to count the duration that the VM is in the state and report the value...
> We would like to have the information for the time the VM is in a state from the time it moved to it. So what's wrong with a timestamp?...
@Barakmor1 can you please change the PR title to something like `Add libvmi options for CPU resources, SerialBIOS and ClientPassthrough`?