Fred Hornsey

Results 141 comments of Fred Hornsey

This is what #21 was meant to solve, unfortunately, it has yet to be accepted. If you wanted this to work at the moment you could install my fork or,...

> We're not using gnuautobuild anywhere, as far as I know. Should it be added to this repo's CI build? I don't know what gnuautobuild is exactly, but why would...

> https://github.com/DOCGroup/ACE_TAO/blob/master/ACE/bin/MakeProjectCreator/modules/GNUAutobuildWorkspaceCreator.pm I stand corrected. I thought it wasn't here because I ran `grep -RnI gnuautobuild .` on the ACE_TAO tree, but that's case sensitive. How is the MPC type...

> --output-sync is a GNU make 4.0 feature, see https://lists.gnu.org/archive/html/make-w32/2013-10/msg00021.html. RHEL7 has GNU make 3.82 so we can't use this option I can see how this feature would be useful...

Looks good so far! I just remembered this. There's a C preprocessor file I added that states what features the IDL compiler supports. It should be updated to state it...

> And I'll be honest I'm doing this more for the fun and experience of it rather than for a particular purpose, so I'll do whatever makes this as complete...

Sorta. You have to escape that because we added support for IDL4 `int16` and similar types in #840, which are now reserved keywords like `short` is. Also I'm not sure...

The complex method complaint is normal and personally I think it's being over zealous in this case since the function is only about 120 lines long, although it's probably counting...

> I find it less obvious which file is included It is missing the other part I'm trying to do in OpenDDS which is just using `#include ` for non-relative...

If I understand you correctly, do you mean for example using `ace/Reactor.h` instead something like of `../../ace/Reactor.h` in a test? If so I agree with you and these changes don't...