ACE_TAO icon indicating copy to clipboard operation
ACE_TAO copied to clipboard
verified publisher icon DOCGroup

Improved support on Windows platforms with differing IPv4/IPv6 support

Open wkbrd opened this issue 6 years ago • 4 comments

Improved support on Windows platforms with differing IPv4/IPv6 support, including over network segments. It was found that on Windows sometimes IPv4 traffic would not connect due to the results of name lookups.

This change corrects this behavior and we have been utilizing the same patched files on both Windows and Linux.

Summary by CodeRabbit

  • New Features
    • Enhanced network address resolution now gracefully evaluates multiple address options, providing improved connectivity.
    • Improved support for Windows ensures smoother, more compatible network operations.

wkbrd avatar Aug 29 '19 13:08 wkbrd

Hi @jwillemsen, what is the process for having this pull request be considered? Does the code complexity (CodeFactor) need to be addressed or can it be accepted by a project team member's review?

wkbrd avatar Sep 10 '19 19:09 wkbrd

The complex method complaint is normal and personally I think it's being over zealous in this case since the function is only about 120 lines long, although it's probably counting the possible code paths. As for acceptance, it's not directly based on what checks are saying, someone who with free time will have to review it.

iguessthislldo avatar Sep 10 '19 19:09 iguessthislldo

Acceptance requires a detailed review which depens on available time. Also the person who merges a PR implicitly commits to check all builds to watch for any regression. All together it takes several hours for one PR, see also https://htmlpreview.github.io/?https://github.com/DOCGroup/ACE_TAO/blob/master/ACE/docs/ACE-bug-process.html

jwillemsen avatar Sep 10 '19 20:09 jwillemsen