Martin
Martin
Will review tomorrow morning.
Why the need for inversion of the logic?
> I'm fine with either of the icon ideas but the greater esports community might not be as receptive to having a skull next to someone who died that was...
> Given most of the changes happen to `Array.mapIndexes`, would it make sense to add a second version of that, e.g. `forEachIndexed` or something, which would not return anything? Iterating...
> can you check if it breaks infoboxes with fixed image size? > > example page: https://liquipedia.net/starcraft2/Stimpack > > from preview it looks broken to me but i can not...
- Removed the percent based size stuff was it was used on only two dota2 pages where the same result is already achieved with `max-height` CSS on the image itself....
> imo pass both dark and lightmode version to image module at the same time As I mentioned in the comment, I can't do that because of differences in how...
> lgtm if tested please also test on sc2/sc/wc/stormgate due to /custom being used there Those 3 override `readEntry()` with their own function which still has the assert on not...
> I'm skeptical, this would have significant impact on the functioning on player's of the team in other places. Such as earnings of player, player results, player matches, upcoming matches...
Pushed change to all the customs and added fallback to not index entries table by nil when team template for the opponent doesn't exist and hence no name field. Mixing...