feat(portal players): change color for deceased persons
Summary
Change background color for deceased players
I think from a stylistic sense, either birthdate or age, but not both CC @iMarbot @muriloricci
Not sure if Birthdate, Deathdate and Age all belong in a column called "Age". Wouldn't just the age be appropriate?
Not sure if Birthdate, Deathdate, and Age all belong in a column called "Age". Wouldn't just the age be appropriate?
I feel like Age works for these things because it shows that if they were born on April 4th, 1996 they would be 27 years old. Birthdate and deathdate are used for extra detail imo. The age of the person is the info that their birthdate provides and the calculator does the math for you and shows their age. I don't feel like the Age being in brackets denotes that it is a property with less value.
Not sure if Birthdate, Deathdate and Age all belong in a column called "Age". Wouldn't just the age be appropriate?
I also can't think of an alternative title that would fulfill the things being displayed
Not sure if Birthdate, Deathdate and Age all belong in a column called "Age". Wouldn't just the age be appropriate?
I also can't think of an alternative title that would fulfill the things being displayed
I think showing just the age is better. Additionally, I have a concern on how it would look for deceased people if that information is also shown
Additionally, I have a concern on how it would look for deceased people if that information is also shown
We show deathdate if that is what you're asking. https://liquipedia.net/formula1/Portal:Drivers/Europe All with gray background are deceased.
Additionally, I have a concern on how it would look for deceased people if that information is also shown
We show deathdate if that is what you're asking. https://liquipedia.net/formula1/Portal:Drivers/Europe All with gray background are deceased.
Yes and it looks super strange
We show deathdate if that is what you're asking. https://liquipedia.net/formula1/Portal:Drivers/Europe All with gray background are deceased.
Yes and it looks super strange
I don't know if there is another way it could be organized and still fit into the table.
Which is why I'm suggesting to remove it
Which is why I'm suggesting to remove it
the whole age display or just the deathdate?
Could it be an option to show dates for deceased persons, age for everyone else?
I have a new idea. What if we show their exact age. Years-days, and just exclude birthdates and deathdates all together. This would also clear up our issue on what to title the category.
Like how the Fortnite stats page shows it.
Sure, though I'm not sure that days are needed tbh but if you really want
Sure, though I'm not sure that days are needed tbh but if you really want
I would rather have the current version honestly. So far I've trialed the new version on R6 and Crossfire. I haven't heard much feedback other than it looks fine. Only 2 people responded though lol https://discord.com/channels/93055209017729024/315607343331278848/1211756009643581440
Pls lmk any other suggestion you have
I'll also work on the new idea as a proof of concept
I'll also work on the new idea as a proof of concept
I got it to work but it looked terrible. I'm going to argue that we should push it as is (assuming code style is up to standard) I really do like how this one looks atm, none of the people I've received feedback from have any problems with it. Idk what y'all think about having a poll on the editors' announcement channel asking if the additions to the portal are wanted or not, it would be a nice idea.
Well there has been 2 pieces of feedback here (from me and Martin) that as it's now, it doesn't make sense
Well there has been 2 pieces of feedback here (from me and Martin) that as it's now, it doesn't make sense
That is true haha. Ok new ideas, We could go with what mBergen said: Could it be an option to show dates for deceased persons, age for everyone else? Or we could just kick age entirely and only show birthdates (and deathdates if applicable).
Show Age and only age (eg 31 years old), for dead people, don't show age, but something else (like a skull or text that's deceased or smt)
Show Age and only age (eg 31 years old), for dead people, don't show age, but something else (like a skull or text that's
deceasedor smt)
The skull is a little much lol. I like the idea of having a tag that says Deceased. Fwiw the background for deceased is gray-bg so it's hard to miss.
Show Age and only age (eg 31 years old), for dead people, don't show age, but something else (like a skull or text that's
deceasedor smt)The skull is a little much lol. I like the idea of having a tag that says Deceased. Fwiw the background for deceased is gray-bg so it's hard to miss.
To quote my designer, icons are better than coloring, unless the color is superclear what it mean
The skull is a little much lol. I like the idea of having a tag that says Deceased. Fwiw the background for deceased is gray-bg so it's hard to miss.
To quote my designer, icons are better than coloring, unless the color is superclear what it mean
I'm fine with either of the icon ideas but the greater esports community might not be as receptive to having a skull next to someone who died that was a part of the scene they follow so closely. So I'd say the Deceased tag would be best
I'm fine with either of the icon ideas but the greater esports community might not be as receptive to having a skull next to someone who died that was a part of the scene they follow so closely. So I'd say the Deceased tag would be best
I agree that the skull icon might be a bit insensitive. Regarding "deceased", we use "passed away" in infoboxes and stuff, so we should be consistent with that, imo.
I agree that the skull icon might be a bit insensitive. Regarding "deceased", we use "passed away" in infoboxes and stuff, so we should be consistent with that, imo.
Yes we do have to stay consistent, even though I'm still in disagreement over that decision. Also I think the idea of having the option to show dates for deceased persons is also a good one.
I agree that the skull icon might be a bit insensitive. Regarding "deceased", we use "passed away" in infoboxes and stuff, so we should be consistent with that, imo.
Yes we do have to stay consistent, even though I'm still in disagreement over that decision. Also I think the idea of having the option to show dates for deceased persons is also a good one.
Could show deceased people as Passed Away (1967 - 1991)
That works for me. I'm going to be OOO for most of the week so I can't really continue dev work on it, so if someone wants to apply these new ideas that would be nice. If not, I might be able to get to it Friday. :)
Could show deceased people as
Passed Away (1967 - 1991)
Coming back to this. I don't like the unspecificity of just showing years, what about something like
(1967-02-09) - (1991-03-04)
Or something to this effect
What about a dagger mark before or after the name? I've seen it a couple of times on wikipedia https://en.wikipedia.org/wiki/Dagger_(mark)#:~:text=When%20placed%20immediately%20before%20or,symbol%20indicates%20an%20obsolete%20word.
Coming back to this. I don't like the unspecificity of just showing years, what about something like
(1967-02-09) - (1991-03-04)Or something to this effect
I don't think it is a relevant use of space in the portal. If someone is interested, they should go to the page and can see the full dates there.
What about a dagger mark before or after the name? I've seen it a couple of times on wikipedia
That's a nice idea, i like that!
dagger mark icon okay for me
