Lua-Modules icon indicating copy to clipboard operation
Lua-Modules copied to clipboard

feat(portal players): change color for deceased persons

Open iamentry opened this issue 1 year ago • 37 comments

Summary

Change background color for deceased players

iamentry avatar Feb 20 '24 16:02 iamentry

I think from a stylistic sense, either birthdate or age, but not both CC @iMarbot @muriloricci

Rathoz avatar Feb 20 '24 17:02 Rathoz

Not sure if Birthdate, Deathdate and Age all belong in a column called "Age". Wouldn't just the age be appropriate?

Rathoz avatar Feb 21 '24 14:02 Rathoz

Not sure if Birthdate, Deathdate, and Age all belong in a column called "Age". Wouldn't just the age be appropriate?

I feel like Age works for these things because it shows that if they were born on April 4th, 1996 they would be 27 years old. Birthdate and deathdate are used for extra detail imo. The age of the person is the info that their birthdate provides and the calculator does the math for you and shows their age. I don't feel like the Age being in brackets denotes that it is a property with less value.

iamentry avatar Feb 21 '24 15:02 iamentry

Not sure if Birthdate, Deathdate and Age all belong in a column called "Age". Wouldn't just the age be appropriate?

I also can't think of an alternative title that would fulfill the things being displayed

iamentry avatar Feb 22 '24 17:02 iamentry

Not sure if Birthdate, Deathdate and Age all belong in a column called "Age". Wouldn't just the age be appropriate?

I also can't think of an alternative title that would fulfill the things being displayed

I think showing just the age is better. Additionally, I have a concern on how it would look for deceased people if that information is also shown

Rathoz avatar Feb 23 '24 13:02 Rathoz

Additionally, I have a concern on how it would look for deceased people if that information is also shown

We show deathdate if that is what you're asking. https://liquipedia.net/formula1/Portal:Drivers/Europe All with gray background are deceased.

iamentry avatar Feb 23 '24 13:02 iamentry

Additionally, I have a concern on how it would look for deceased people if that information is also shown

We show deathdate if that is what you're asking. https://liquipedia.net/formula1/Portal:Drivers/Europe All with gray background are deceased.

Yes and it looks super strange image

Rathoz avatar Feb 23 '24 13:02 Rathoz

We show deathdate if that is what you're asking. https://liquipedia.net/formula1/Portal:Drivers/Europe All with gray background are deceased.

Yes and it looks super strange image

I don't know if there is another way it could be organized and still fit into the table.

iamentry avatar Feb 23 '24 13:02 iamentry

Which is why I'm suggesting to remove it

Rathoz avatar Feb 23 '24 13:02 Rathoz

Which is why I'm suggesting to remove it

the whole age display or just the deathdate?

iamentry avatar Feb 23 '24 13:02 iamentry

Could it be an option to show dates for deceased persons, age for everyone else?

mbergen avatar Feb 23 '24 15:02 mbergen

I have a new idea. What if we show their exact age. Years-days, and just exclude birthdates and deathdates all together. This would also clear up our issue on what to title the category. Like how the Fortnite stats page shows it. Screen Shot 2024-02-23 at 9 46 02 AM

iamentry avatar Feb 23 '24 15:02 iamentry

Sure, though I'm not sure that days are needed tbh but if you really want

Rathoz avatar Feb 27 '24 10:02 Rathoz

Sure, though I'm not sure that days are needed tbh but if you really want

I would rather have the current version honestly. So far I've trialed the new version on R6 and Crossfire. I haven't heard much feedback other than it looks fine. Only 2 people responded though lol https://discord.com/channels/93055209017729024/315607343331278848/1211756009643581440

Pls lmk any other suggestion you have

iamentry avatar Feb 27 '24 18:02 iamentry

I'll also work on the new idea as a proof of concept

iamentry avatar Feb 27 '24 19:02 iamentry

I'll also work on the new idea as a proof of concept

I got it to work but it looked terrible. I'm going to argue that we should push it as is (assuming code style is up to standard) I really do like how this one looks atm, none of the people I've received feedback from have any problems with it. Idk what y'all think about having a poll on the editors' announcement channel asking if the additions to the portal are wanted or not, it would be a nice idea.

iamentry avatar Feb 27 '24 21:02 iamentry

Well there has been 2 pieces of feedback here (from me and Martin) that as it's now, it doesn't make sense

Rathoz avatar Feb 28 '24 10:02 Rathoz

Well there has been 2 pieces of feedback here (from me and Martin) that as it's now, it doesn't make sense

That is true haha. Ok new ideas, We could go with what mBergen said: Could it be an option to show dates for deceased persons, age for everyone else? Or we could just kick age entirely and only show birthdates (and deathdates if applicable).

iamentry avatar Feb 28 '24 14:02 iamentry

Show Age and only age (eg 31 years old), for dead people, don't show age, but something else (like a skull or text that's deceased or smt)

Rathoz avatar Feb 29 '24 13:02 Rathoz

Show Age and only age (eg 31 years old), for dead people, don't show age, but something else (like a skull or text that's deceased or smt)

The skull is a little much lol. I like the idea of having a tag that says Deceased. Fwiw the background for deceased is gray-bg so it's hard to miss.

iamentry avatar Feb 29 '24 14:02 iamentry

Show Age and only age (eg 31 years old), for dead people, don't show age, but something else (like a skull or text that's deceased or smt)

The skull is a little much lol. I like the idea of having a tag that says Deceased. Fwiw the background for deceased is gray-bg so it's hard to miss.

To quote my designer, icons are better than coloring, unless the color is superclear what it mean

Rathoz avatar Mar 01 '24 11:03 Rathoz

The skull is a little much lol. I like the idea of having a tag that says Deceased. Fwiw the background for deceased is gray-bg so it's hard to miss.

To quote my designer, icons are better than coloring, unless the color is superclear what it mean

I'm fine with either of the icon ideas but the greater esports community might not be as receptive to having a skull next to someone who died that was a part of the scene they follow so closely. So I'd say the Deceased tag would be best

iamentry avatar Mar 01 '24 19:03 iamentry

I'm fine with either of the icon ideas but the greater esports community might not be as receptive to having a skull next to someone who died that was a part of the scene they follow so closely. So I'd say the Deceased tag would be best

I agree that the skull icon might be a bit insensitive. Regarding "deceased", we use "passed away" in infoboxes and stuff, so we should be consistent with that, imo.

iMarbot avatar Mar 01 '24 19:03 iMarbot

I agree that the skull icon might be a bit insensitive. Regarding "deceased", we use "passed away" in infoboxes and stuff, so we should be consistent with that, imo.

Yes we do have to stay consistent, even though I'm still in disagreement over that decision. Also I think the idea of having the option to show dates for deceased persons is also a good one.

iamentry avatar Mar 01 '24 20:03 iamentry

I agree that the skull icon might be a bit insensitive. Regarding "deceased", we use "passed away" in infoboxes and stuff, so we should be consistent with that, imo.

Yes we do have to stay consistent, even though I'm still in disagreement over that decision. Also I think the idea of having the option to show dates for deceased persons is also a good one.

Could show deceased people as Passed Away (1967 - 1991)

Rathoz avatar Mar 04 '24 09:03 Rathoz

That works for me. I'm going to be OOO for most of the week so I can't really continue dev work on it, so if someone wants to apply these new ideas that would be nice. If not, I might be able to get to it Friday. :)

iamentry avatar Mar 04 '24 12:03 iamentry

Could show deceased people as Passed Away (1967 - 1991)

Coming back to this. I don't like the unspecificity of just showing years, what about something like (1967-02-09) - (1991-03-04) Or something to this effect

iamentry avatar Apr 09 '24 15:04 iamentry

What about a dagger mark before or after the name? I've seen it a couple of times on wikipedia https://en.wikipedia.org/wiki/Dagger_(mark)#:~:text=When%20placed%20immediately%20before%20or,symbol%20indicates%20an%20obsolete%20word.

liquidely avatar Apr 26 '24 14:04 liquidely

Coming back to this. I don't like the unspecificity of just showing years, what about something like (1967-02-09) - (1991-03-04) Or something to this effect

I don't think it is a relevant use of space in the portal. If someone is interested, they should go to the page and can see the full dates there.

What about a dagger mark before or after the name? I've seen it a couple of times on wikipedia

That's a nice idea, i like that!

mbergen avatar Apr 26 '24 14:04 mbergen

dagger mark icon okay for me

hjpalpha avatar Apr 26 '24 15:04 hjpalpha