Yongtao Huang

icon indicating an email [email protected]

icon location Beijing

Results 6 comments of Yongtao Huang

change type of logerrors in pg_exttable from char to boolean

> Code change seems fine. > > Lazy question on some history: do you know why it is changed to `char` ? @kainwen Thanks. The metadata of gpdb7 had better...

change type of logerrors in pg_exttable from char to boolean

> -1. Backup & restore on Greenplum 7 will lose information, won't it? @adam8157 Hi Adam, the pr doesn't affect any code logic of LOG ERRORS PERSISTENTLY. As the result...

change type of logerrors in pg_exttable from char to boolean

> Oh, the full meta is stored in the foreign table catalog, is it? I'm fine if backup & restore would work in that way. Thanks. Yes, all the infos...

Fix: ensure Error classes are instantiated before raising

/gemini review

gh-142750: Normalize ParamSpec __bound__ when bound is None

Thanks for the review! 🙂 I've added a NEWS entry and a test case to cover the `ParamSpec(..., bound=None)` behavior. Test case passed locally. ``` bash D:\MyCode\cpython>PCbuild\amd64\python_d.exe -m test test_typing.py...

Feat: pyright helps dify remove dead var and func

I think following the rule of ruff is a good choice. Close this PR. Thanks for your review.