Fix: ensure Error classes are instantiated before raising
Fixes #27180
Previously, many raise XXXError statements were missing parentheses, causing exception classes to be raised instead of instances. This broke normal error propagation — error handlers, loggers, and response mappers could not access exception attributes or messages.
This patch standardizes all raise statements to instantiate the exception (raise XXXError()), restoring consistent error handling and preventing subtle runtime issues.
Summary
Screenshots
Checklist
- [ ] This change requires a documentation update, included: Dify Document
- [x] I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
- [x] I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
- [x] I've updated the documentation accordingly.
- [x] I ran
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods
Summary of Changes
Hello @hyongtao-code, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a fundamental Python error handling pattern by ensuring that all exceptions are properly instantiated when raised. Previously, many raise statements were missing the necessary parentheses, leading to exception classes being raised directly instead of their instances. This oversight could cause issues with error propagation and prevent proper access to exception details. The changes standardize these statements, thereby restoring consistent and robust error handling across the application.
Highlights
-
Standardized Exception Instantiation: All
raisestatements throughout the codebase have been updated to correctly instantiate exception classes by adding parentheses (e.g.,raise MyError()instead ofraise MyError). - Improved Error Handling: This change ensures proper error propagation, allowing error handlers, loggers, and response mappers to correctly access exception attributes and messages, which was previously hindered by uninstantiated exception classes.
- Enhanced Code Robustness: By consistently instantiating exceptions, the system avoids subtle runtime issues and improves the overall reliability and predictability of error management.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.
/gemini review