Acto Team issues

Results 43 issues of


                                            Acto Team

Incorrect Follower Upscaling Behavior

Before going into the report, thank you so much for recognizing our issues and even provided fix for them. We really appreciate that! **What version of redis operator are you...

bug

Quantity type's validation does not conform to its serialization specification

### What happened? We found that the the serialization specification for the `Quantity` type does not conform to the real implementation of parse function. The serialization specification is found here...

kind/bug

sig/api-machinery

help wanted

triage/accepted

APIVersion of PersistentVolumeClaim is hardcoded while the CRD allows specifying other versions

### Expected behaviour redis-operator should allow users to specify the APIVersion to use for PersistentVolumeClaim through the field `Spec.Redis.Storage.PersistentVolumeClaim.apiVersion` exposed in the CRD. ### Actual behaviour We noticed that although...

stale

fix: avoid silent rejection to invalid `podManagementPolicy`

### What problem does this PR solve? This PR solves the problem mentioned in https://github.com/pingcap/tidb-operator/issues/4649. Basically, we believe an invalid `podManagementPolicy` should not be silently replaced by some default values...

needs-rebase

`podManagementPolicy` silently changes to `Parallel` if the value is invalid

## Bug Report **What version of Kubernetes are you using?** ```shell Client Version: version.Info{Major:"1", Minor:"17", GitVersion:"v1.17.1", GitCommit:"d224476cd0730baca2b6e357d144171ed74192d6", GitTreeState:"clean", BuildDate:"2020-01-14T21:04:32Z", GoVersion:"go1.13.5", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"22", GitVersion:"v1.22.9", GitCommit:"6df4433e288edc9c40c2e344eb336f63fad45cd2", GitTreeState:"clean", BuildDate:"2022-05-19T19:53:08Z",...

Validate `resources.request.storage` for each item in `spec.tiflash.storageClaims`

### What problem does this PR solve? This PR solves the problem that assigning empty objects under `storageClaims` of tiflash can bypass the validation of the operator. We found that...

status/LGT2

`validatePDSpec` does not validate `Spec.PD.Service`

## Bug Report **What version of Kubernetes are you using?** ```shell Client Version: version.Info{Major:"1", Minor:"24", GitVersion:"v1.24.0", GitCommit:"4ce5a8954017644c5420bae81d72b09b735c21f0", GitTreeState:"clean", BuildDate:"2022-05-03T13:46:05Z", GoVersion:"go1.18.1", Compiler:"gc", Platform:"linux/amd64"} Server Version: [version.Info]([[http://version.info/){Major](http://version.info/)%7BMajor)](http://version.info/)%7BMajor](http://version.info/)%7BMajor)):"1", Minor:"22", GitVersion:"v1.22.9", GitCommit:"6df4433e288edc9c40c2e344eb336f63fad45cd2", GitTreeState:"clean", BuildDate:"2022-05-19T19:53:08Z",...

`configUpdateStrategy` is a field of `discovery` but it is never used

operator is not able to create pump pods when `spec.pump.resources.request.storage` is missing

Empty objects under `storageClaims` bypass TiDB’s validation

## Bug Report **What version of Kubernetes are you using?** ```shell Client Version: [version.Info](http://version.info/){Major:“1”, Minor:“17", GitVersion:“v1.17.1”, GitCommit:“d224476cd0730baca2b6e357d144171ed74192d6", GitTreeState:“clean”, BuildDate:“2020-01-14T21:04:32Z”, GoVersion:“go1.13.5”, Compiler:“gc”, Platform:“linux/amd64”} Server Version: [version.Info](http://version.info/){Major:“1", Minor:“22”, GitVersion:“v1.22.9", GitCommit:“6df4433e288edc9c40c2e344eb336f63fad45cd2”, GitTreeState:“clean”, BuildDate:“2022-05-19T19:53:08Z”,...