Acto Team

Results 33 comments of Acto Team

Hi, @mikechengwei Thanks for your reply. Yes, you are absolutely correct, the operator validates the storageClaims by checking the length of the slice, if the length is smaller than 1,...

> @hoyhbx Please rebase this PR, thanks! @DanielZhangQD It's done now.

Hi @chrisseto, thanks for your reply > Do you terminate TLS at your ingress controller and then re-establish it between the ingress controller and CockroachDB? yeah I think this could...

Thanks for your response. We have added a unit test in our latest commit.

The validation does not come from the kubernetes' parsing, but from a component called unmarshalerDecoder. I am still trying to find where exactly this component is implemented, but there is...

Thanks for the pointers, sorry I didn't see the error message that the parseQuantityString was returning. I think we should use a regex that conform to the validation used by...

> I'd also note that [the documentation of what is permitted](https://github.com/kubernetes/kubernetes/blob/f02682c628c530219966a00ae002d799f0d813dc/staging/src/k8s.io/apimachinery/pkg/api/resource/quantity.go#L31-L66) is incorrect with regards to what `parseQuantityString` actually allows. (e.g. `n` and `u` are permitted as suffixes) Yeah I...

Hi @Porges , I realized the regex above has a little typo. The regex for number should be ``` var number = `((\.[0-9]+)|([0-9]+(\.[0-9]+)?)|([0-9]+\.))` ``` instead of ``` var number =...

Got it, thanks for the confirmation! We are also happy to contribute if you have plans to fix it:)