Howard Tinghao Chen
Howard Tinghao Chen
When I ran the command mentioned in https://github.com/google/tink/issues/392, I got a lot of warning messages when I specified the `--master-key-uri` with `aws-kms`: ``` MacBook-Pro:dir user$ tinkey create-keyset --out=keyset.json --key-template=ECIES_P256_HKDF_HMAC_SHA256_AES128_GCM --master-key-uri=aws-kms://......
### What version are you using? txnbuild v10.0.0. (master) ### What did you do? I checked the code and found out that the BumpSequence [validate](https://github.com/stellar/go/blob/ece49d110dd2c68d3ace79bf1fc4bb061a280e9d/txnbuild/bump_sequence.go#L42-L48) function incorrectly uses the `validateAmount`...
**Why** We've started to reference to sandwich transactions since the introduction of CAP-33 and CAP-18. We talked about the ["sandwich approach"](https://github.com/stellar/stellar-protocol/blob/d750a41be602ff2b79627c7cd3c3cd1628435ed4/core/cap-0033.md#sponsorship-logic-is-off-chain) in CAP-33, and we also talked about the [authorization...
### Background story The links on [this](https://aws.github.io/aws-sdk-go-v2/docs/code-examples/kms/) page take people to [this](https://github.com/awsdocs/aws-doc-sdk-examples/tree/main/gov2) page, and kms examples are nowhere to be found. The documentation also doesn't explain how we can mock...
We don't have to embed `App` struct in actions. Instead, we can make `App` a pointer receiver of the actual function. `App` actually shouldn't be a part of an `Action`....
The functions in the file are all the same except the type of pointer receivers. We should be able to simplify it after we finish https://github.com/stellar/go/issues/869.
PR Checklist ### PR Structure * [x] This PR has reasonably narrow scope (if not, break it down into smaller PRs). * [x] This PR avoids mixing refactoring changes with...