Howard Tinghao Chen
Howard Tinghao Chen
Alternatively, if we can make the `approval_criteria` so that people can specify the transaction composition as one of the criteria, it would also work.
Are we implicitly saying that clients should always: 1. submit the transaction containing only the middle operations of a sandwich 2. get a `revised` transaction, which is a sandwich transaction,...
> What is the benefit of this? We give back the signed transaction in step 2 and go for it (we add a time bound, but that's not even necessary)....
> So in general, the job of the approval servers (at least ours) tends to not be to validate transaction composition. That's merely a byproduct. It's approving the intent (in...
Based on the conversations in this PR, looks like we all agree on starting with a definition for a sandwich transaction in our developer documentations. And it should improve the...
@Shaptic @leighmcculloch PTAL again. If you still prefer a more holistic approach, I can close this PR.
> Can you elaborate on the contents of `getOperationsForAccount` and similar functions? Are you going to move actions code there? `getOperationsForAccount` itself will not be in the `actions` package. It...
@tomquisel My gut feeling is that it won't take that long (definitely not a year). I plan on having an experimental branch working on a single endpoint to start small,...
https://github.com/stellar/go/pull/894 ^ I just hit a milestone here @tomquisel @bartekn cc @tomerweller