Omri Himelbrand comments

Results 16 comments of


                                            Omri Himelbrand

[Feature request] - onLongPress functionality.

Hi @scarfex, actually, that's a nice idea, I need to do some thinking about how exactly to implement it. the main concern is the timing of visual changes and calling...

[Feature request] - onLongPress functionality.

@scarfex I think I see what the problem is. did you bind the functions: stopInc & stopDec ? since you used classic function and not an assignment of an anonymous...

[Feature request] - onLongPress functionality.

@scarfex great. so I think that what's missing in the implementation is a prop that will hold a boolean that defines the following behavior: should the onChange be called every...

Enable styles for buttons as well as enable disabling and enabling buttons

Cool, thanks! If you still wish to merge this, please add the new props to README

Enable styles for buttons as well as enable disabling and enabling buttons

Thanks a lot for your contribution!

Enable styles for buttons as well as enable disabling and enabling buttons

I'll review it this weekend, I missed the notification sorry

Looking for maintainers for this project

@smallsaucepan from what I can tell you've been coding for a long time. I also looked at your repo and it really looks that you are on top of things....

[BUG] - I'm having an issue with changing value dynamically

> I am having the same issue. When `props.value` changes, The `NumericInput` `state.value` does not update. `NumericInput` rerenders, but the value of `state.value` remains the same. > Checking for that...

Editable props is only disabled the TextInput, But it should disabled the Button as well.

I'll add a prop for this as soon as I get a chance. thank you for opening this issue

Use TextStyle for iconStyle

Thanks a lot for your contribution! Please make it possible to use one or the other... depending on need