react-native-numeric-input icon indicating copy to clipboard operation
react-native-numeric-input copied to clipboard

Enable styles for buttons as well as enable disabling and enabling buttons

Open Monir-Shembesh opened this issue 5 years ago • 5 comments

Sorry for the hassle of making one pull request to all features, but thought it would make sense.

I am currently working on a project and found out that I need to disable the increment and decrement buttons when the user reaches the max or min values specified.

Therefore, the following was done:

1- add expected props to the typescript interface following a previous name convention used with the icon styles 2- change the style prop on the increment and decrement to be an array 3- spread the upcoming props that are related to the button styles if true other wise just use {} 4- add a disabled prop to the buttons 5- write a condition inside the disabled prop that checks if the max/min reached as well if the user passed the disablers props disableIncButtonOnMaxReach and disableDecButtonOnMaxReach

Happy to make any necessary changes after reviewing

Monir-Shembesh avatar Jul 13 '20 17:07 Monir-Shembesh

Cool, thanks! If you still wish to merge this, please add the new props to README

himelbrand avatar Jan 29 '22 15:01 himelbrand

Thanks a lot for your contribution!

himelbrand avatar Jan 29 '22 15:01 himelbrand

Hi, yes please merge it i have updated the README, revised the code, as well as fixed a typo in the types file.

Monir-Shembesh avatar Jan 29 '22 17:01 Monir-Shembesh

@himelbrand can you please merge this pull request?

Monir-Shembesh avatar Jan 30 '22 09:01 Monir-Shembesh

I'll review it this weekend, I missed the notification sorry

himelbrand avatar Feb 16 '22 00:02 himelbrand