Hendra Wijaya Djiono

Results 42 comments of Hendra Wijaya Djiono

I think keeping Dialog in `private static ProgressDialog mProgressDialog;` as static variable might lead to Activity leak, since it will keep the reference to the activity context then the activity...

Related to #53

Is your application already uploaded to google play store?

Do you have a proof of the memory leak? Because I don't find any code that could lead to memory leak in https://github.com/hotchemi/Android-Rate/blob/master/library/src/main/java/hotchemi/android/rate/AppRate.java and https://github.com/hotchemi/Android-Rate/blob/master/library/src/main/java/hotchemi/android/rate/DialogManager.java

I think this feature would be great for flexibility of this library

The support for the other app stores is good, but can we set custom action to the button? For example, I want to open my custom **RateActivity** when the **Rate**...

There might be an error with the travis configuration, since i edited non-code files and it results in build failed.

What are the best practices to implement this function? Since i need this functionality too, you could give me some advices and maybe i could send pull request to implement...

I got the same error, but don't know how to submit a new issue here. Here is my stack trace: ``` Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'void...

Still no update for this? `Caused by: java.lang.RuntimeException: Manifest merger failed : uses-sdk:minSdkVersion 14 cannot be smaller than version 19 declared in library [com.rafakob:floatingedittext:1.0.5] /Users/hendrawd/.gradle/caches/transforms-1/files-1.1/jetified-floatingedittext-1.0.5.aar/be838385a31a208f7b193ad356453237/AndroidManifest.xml as the library might be...