Android-Rate icon indicating copy to clipboard operation
Android-Rate copied to clipboard

A memory leak occurs when the screen rotates

Open taka-me opened this issue 8 years ago • 2 comments

If we do not use the Dialog Fragment or showDialog method, it seems that the dialog does not regenerate when the screen rotates, causing a memory leak.

taka-me avatar May 22 '17 10:05 taka-me

Do you have a proof of the memory leak? Because I don't find any code that could lead to memory leak in https://github.com/hotchemi/Android-Rate/blob/master/library/src/main/java/hotchemi/android/rate/AppRate.java and https://github.com/hotchemi/Android-Rate/blob/master/library/src/main/java/hotchemi/android/rate/DialogManager.java

hendrawd avatar Dec 27 '17 03:12 hendrawd

@taka-me @haijima Fixed in https://github.com/Vorlonsoft/AndroidRate (Release 1.1.6+). Could you check it and confirm it? Fix was in AppRate.java: private static AppRate singleton; changed to private static volatile AppRate singleton = null;

AlexanderLS avatar Apr 27 '18 17:04 AlexanderLS