Stephen Halter

Results 46 issues of Stephen Halter

### Describe the bug HTTP/2 WebSockets (or any extended CONNECT) should not be limited by Kestrel's `MaxRequestBodySize` or `MinRequestBodyDataRate`, but currently HTTP/2 WebSockets is limited by both. Furthermore, it should...

area-runtime
servers-kestrel

## Background and Motivation With #43000, we've approved adding `RequestDelegateFactoryOptions.EndpointBuilder` and `EndpointFilterFactoryContext.EndpointBuilder` so filters can get full access to more metadata like the `RoutePattern` (with a downcast) and `DisplayName`. I...

api-needs-work
area-web-frameworks

## Background and Motivation In reaction to #42592, I think we should expose the entire `EndopintBuilder` via `RequestDelegateFactoryOptions`. This would allow downcasting to `RouteEndpointBuilder` and seeing the `RoutePattern` too from...

api-approved
area-web-frameworks

[The "ASP.NET Core Performance Best Practices" doc](https://docs.microsoft.com/en-us/aspnet/core/performance/performance-best-practices?view=aspnetcore-6.0) covers more than just performance. We already include general guidance in sections like [Do not use the HttpContext after the request is complete](https://docs.microsoft.com/en-us/aspnet/core/performance/performance-best-practices?view=aspnetcore-6.0#do-not-use-the-httpcontext-after-the-request-is-complete)...

doc-idea

TODO: Fix the flaky tests. Here are the failures I currently see locally ``` Firefox 94.0 (Windows 10) Redirect Functional Tests Original URL used when client stops after a redirect...

``` ‌HeadlessChrome 0.0.0 (Windows 10 0.0.0): Executed 164 of 168 (skipped 4)‌ SUCCESS‌ (56.813 secs / 56.649 secs)‌ Firefox 64.0.0 (Windows 10 0.0.0): Executed 1 of 168‌ SUCCESS‌ (0 secs...

**Describe the bug** This seems possibly related to https://github.com/VsVim/VsVim/issues/2515. When I Ctrl+Click a link in a string literal in C#, it brings me to the definition of System.String instead of...

### Description In RC2, the following APIs were renamed or merged. - The `Microsoft.AspNetCore.Builder.DelegateEndpointConventionBuilder` class was renamed to `Microsoft.AspNetCore.Builder.RouteHandlerBuilder`. - The `Microsoft.AspNetCore.Http.OpenApiDelegateEndpointConventionBuilderExtensions` class was renamed to `Microsoft.AspNetCore.Http.OpenApiRouteHandlerBuilderExtensions`. - The `Microsoft.AspNetCore.Builder.DelegateEndpointRouteBuilderExtensions`...

Breaking change
Documented
6.0.0