Stephen Halter
Stephen Halter
Is option 1 suggesting we ship a new NuGet package with a System.Net.Socket-based IConnectionFactory in addition to an IConnectionListenerFactory that we initially copy from what we currently have in-box? If...
This was in the original version of System.IO.Pipelines (called Append like @jkotalik said), but got ripped out in API review because of the usability issues. Kestrel merely had ideas of...
> Return false instead of throwing InvalidOperationException on read of a gRPC server stream after the connection was closed. Wouldn't `BodyReader.ReadStreamMessageAsync` throw anyway if the underlying HTTP/2 connection closed before...
How do the gRPC and .NET conventions differ? I think we should throw OperationCanceledExceptions less than we currently do in Kestrel. See https://github.com/dotnet/aspnetcore/issues/4747#issuecomment-810624765
Triage decision: - Until we have more customer feedback that the current way to configure these `HttpClientHandler/SocketsHttpHandler` options is too cumbersome, we don't think we should add API.
Thanks for the simple repro app. You can fix your issue by passing through response flushes immediately. This way the gRPC trailer-writing logic knows when the response has already started...
> I think this should probably be fixed in gRPC. If the gRPC logic independently tracked if it has written to the body instead of using response.HasStarted, the simpler MemoryStream...
https://docs.microsoft.com/en-us/aspnet/core/migration/50-to-60-samples?view=aspnetcore-6.0#test-with-webapplicationfactory-or-testserver is a migration guide if you're starting from an existing project.
> And the concern about auth is not valid because your connection is authenticated via the connectionToken in the query string. Additionally, if the authenticated user has a non-empty `Context.User.Identity.Name`...
We're planning to make the route pattern an explicit parameter again rather than take it from an attribute which should hopefully reduce "call site complication". https://github.com/dotnet/aspnetcore/issues/30448 With this change, the...