guru kiran
guru kiran
I think building an `exclude-file-types` list based on `file-types` can be done to avoid duplicating the code in FSFinder. I have a PR #192 for this. Is it a good...
> 1. Add unit tests for your changes > 2. Fix issues identified in failed jobs: golangci-lint and goreportcard Done. Pipeline's green. Let me know if there's anything else I...
> @gurukiran07 Please resolve conflicts then I think you're good to go Done.
Will make the requested changes when I get some time today.
> @gurukiran07 Please resolve conflicts and I'll work on getting this merged today @kehoecj Done. Fixed the conflicts. Some basic testing: - with both `exclude-file-types` and `file-types` - with just...
> Do you think you could add the tests I'm talking about here > > [#192 (comment)](https://github.com/Boeing/config-file-validator/pull/192#discussion_r1826531300) Yeah I can. Will work on it when I get some time.