config-file-validator icon indicating copy to clipboard operation
config-file-validator copied to clipboard

add file-types flag

Open gurukiran07 opened this issue 1 year ago • 10 comments

closes #174

Added file-types flag to validator. file-types and exclude-file-types are mutually exclusive. if file-type is set then builds a list of files that can be excluded and sets that value to exclude-file-types flag.

Some rudimentary tests:

with --file-types=yaml image

with --exclude-file-types and --file-types image

gurukiran07 avatar Oct 25 '24 04:10 gurukiran07

  1. Add unit tests for your changes
  2. Fix issues identified in failed jobs: golangci-lint and goreportcard

Done. Pipeline's green. Let me know if there's anything else I need to do. @kehoecj

gurukiran07 avatar Oct 25 '24 17:10 gurukiran07

@gurukiran07 Please resolve conflicts then I think you're good to go

kehoecj avatar Oct 28 '24 14:10 kehoecj

@gurukiran07 Please resolve conflicts then I think you're good to go

Done.

gurukiran07 avatar Oct 28 '24 15:10 gurukiran07

Will make the requested changes when I get some time today.

gurukiran07 avatar Oct 29 '24 21:10 gurukiran07

@gurukiran07 Please resolve conflicts and I'll work on getting this merged today

kehoecj avatar Oct 30 '24 13:10 kehoecj

@gurukiran07 Please resolve conflicts and I'll work on getting this merged today

@kehoecj Done. Fixed the conflicts.

Some basic testing:

  • with both exclude-file-types and file-types image

  • with just file-types image

  • with just exclude-file-types image

gurukiran07 avatar Oct 30 '24 15:10 gurukiran07

Do you think you could add the tests I'm talking about here

#192 (comment)

Yeah I can. Will work on it when I get some time.

gurukiran07 avatar Nov 04 '24 19:11 gurukiran07

@gurukiran07 Please resolve conflicts

kehoecj avatar Dec 17 '24 16:12 kehoecj

@gurukiran07 We probably want this to also be mutually exclusive with the new globbing functionality

kehoecj avatar Dec 18 '24 21:12 kehoecj

@gurukiran07 I would like to get this merged in. Can you please take a look at several outstanding comments?

kehoecj avatar Jan 20 '25 23:01 kehoecj