Matthew (mbg)

Results 8 comments of Matthew (mbg)

This has been merged to the main branch. Thank you for contributing!

Are you looking for an image to do development in? Or an image to run the compiled executables? Or something else?

This should have been fixed with 11863d27a2569ca8238a9b39b25d604635bca642. These should behave as expected in the original issue post if the module is set up. Please let us know if this did...

> there is already a CI job run that executes doc generation, yet the pipeline still finishes successfully. Maybe it would be better to treat warnings as errors? Great suggestion!...

> This could be due to a concurrency safety bug in the current implementation of TinyLfu. Of course, this bug is unrelated to my current PR. I might initiate another...

@MrGlp I think you want to change the name of the variable in that function to `self`. We don't have great coverage of Windows because most of us don't use...

Fixed with commit [59b60f2](https://github.com/cloudflare/pingora/commit/59b60f2c5f146935b940a08a3dd3ec8daadebf82).

Envoy's retry policies are worth looking at here for inspiration/a good set of tunables. https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#envoy-v3-api-msg-config-route-v3-retrypolicy