Greg Miller
Greg Miller
@goankur this can be closed out now right since you opened a separate PR for this change? There's nothing else remaining on this one is there? Thanks again!
Thanks @Yuti-G! This approach looks good to me. Is your plan to iterate on this PR to stop enforcing the ordering checks in all the tests?
Sounds good. Thanks @Yuti-G!
Thanks @jpountz. It might go a long way to just add some comments about the invariants that have to be maintained when updating the score, etc.
@gautamworah96 thanks for the feedback! Adrien and I have been having some conversation around whether-or-not this change makes sense over in the Jira issue. As a result, I'm going to...
I've put this in "Draft" state for now after a suggestion over on the Jira issue to approach this differently. I'll update here (and take out of "Draft") once I've...
This is really interesting/exciting! I'm working through this PR now but I notice you've used a slightly different approach to the FOR encoding (compared to what's done in the postings)....
> and explicitly rejects numbers of bits per value > 32 Ah right, of course this would be an issue here. Thanks for clarifying!
> but the EMPTY vectors instance also returns 0 for the dimension() method, which is something I could see some code paths to complain about if they end up seeing...
Sounds good @shubhamvishu. Thank you!