lucene icon indicating copy to clipboard operation
lucene copied to clipboard
verified publisher icon apache

Lucene-10070

Open goankur opened this issue 4 years ago • 1 comments

Description

Following Facets implementations are changed to ignore deleted documents for count all queries that don't use FacetsCollector instance.

  • SortedSetDocValueFacetCounts
  • ConcurrentSortedSetDocValueFacetCounts
  • LongValueFacetCounts
  • StringValueFacetCounts

Solution

Ignore deleted documents during docValues iteration to calculate facet label counts

Tests

Following test methods have been copied from pull request https://github.com/apache/lucene/pull/263/files (Thanks Greg Miller)

  • TestLongValueFacetCounts.testCountAll()
  • TestStringValueFacetCount.testCountAll()
  • TestSortedSetDocValuesFacets.testCountAll()

Checklist

Please review the following and check all that apply:

  • [X] I have reviewed the guidelines for How to Contribute and my code conforms to the standards described there to the best of my ability.
  • [X] I have created a Jira issue and added the issue ID to my pull request title.
  • [X] I have given Lucene maintainers access to contribute to my PR branch. (optional but recommended)
  • [X] I have developed this patch against the main branch.
  • [X] I have run ./gradlew check.
  • [X] I have added tests for my changes.

goankur avatar Sep 04 '21 03:09 goankur

@goankur this can be closed out now right since you opened a separate PR for this change? There's nothing else remaining on this one is there? Thanks again!

gsmiller avatar Sep 17 '21 17:09 gsmiller

@goankur this can be closed out now right since you opened a separate PR for this change?

Yep this is correct. I am closing this PR.

goankur avatar Nov 03 '23 01:11 goankur