Walter Lee comments

Repositories
Issues
Comments

Results 5 comments of


                                            Walter Lee

Using `--cpu=darwin_x86_64` in `platform_mappings` triggers unnecessary toolchain evaluation

I think we are all in agreement that having a transition in `objc_library` was a mistake. My understanding was that it was put in so that when a linux user...

Improve binary stripping for Apple platforms

Sorry for not responding sooner. I did look into this internally. This commit changes several distinct aspects of binary stripping. It would be better to split each distinct aspect into...

Improve binary stripping for Apple platforms

cpsauer@ I think you're right; it's been a while but the failures I had were from dead_strip of binaries, not dylibs. So we may be able to keep dead_strip on...

Remove objc_library transition

We're not quite ready to do this yet. Internally we still have this transition enabled.

Inclusion validation check should tolerate source file absolute paths

See my comment in #14346.