Remove objc_library transition

[keith]

[googlewalt]

We're not quite ready to do this yet. Internally we still have this transition enabled.

[comius]

Update: We're still not quite ready to do this yet. Internally we still have this transition enabled. :)

[brentleyjones]

Is there a way to make this transition internal to Google then?

[comius]

Is there a way to make this transition internal to Google then?

It's possible. I could spend some time making the transition internal to Google, or towards doing cleanup.

How would that help Bazel? Because you wouldn't be able to flip the flag?

[keith]

I think the biggest benefit is it breaks the dependency on apple_support

[comius]

I think the biggest benefit is it breaks the dependency on apple_support

Ah, I missed that. I'm all for removing dependencies. Consider this PR approved, I'll do the import&changes necessary for internal world.

[comius]

On a side note, is there any objection that I make j2objc_library disappear?

[keith]

As far as we know there are no public users of the j2objc rules

[keith]

I rebased here since this was super out of date, hopefully that's helpful

[brentleyjones]

Thank you @comius!

[meteorcloudy]

Is it possible to backport this to 7.3?

[comius]

Is it possible to backport this to 7.3?

I don't mind. It makes an incompatible flag a no-op, but the behaviour matches with the default settings of the flag.

[meteorcloudy]

@bazel-io fork 7.3.0