gmjw
gmjw
I wanted to mention that I'm not sure how to recreate the image that follows on from the corrected code snipped in the example. Perhaps it will be done automatically?...
Ah, I think the `scale_tril` argument to the GaussianCopulaTriL is wrong. I think ``` scale_tril=[[1., 0.8], [0., 0.6]], ``` should be ``` scale_tril=[[1., 0], [0.8, 0.6]], ``` This seems to...
This is the output of the test adjusted in the PR, with `shared_yaxes=True`, before and after the changes. You can see that after the changes the secondary y-axes are shared...
This is my first PR to this repo, I've done my best but please let me know if there's anything I've forgotten or that could be done better. In particular...
Thanks @gvwilson - just checking in to see if this could be merged soon - thanks!
Hi @gvwilson - just to say that I hope this is ready to merge now, if you have time to review. Thanks!
Hi @emilykl - no rush but just wanted to bump this PR for another look if you have time, many thanks!
If a more experienced contributor takes a look at this - I can't understand why the Circle CI build has failed, the error message doesn't indicate anything clearly - any...