Fix `scale_tril` argument in Gaussian_Copula example notebook

Open gmjw opened this issue 3 years ago • 3 comments

Fix scale_tril argument, so marginals are actually uniform, as stated in the primer text.

See https://github.com/tensorflow/probability/issues/1591

Jul 25 '22 20:07 gmjw

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

Jul 25 '22 20:07 review-notebook-app[bot]

I wanted to mention that I'm not sure how to recreate the image that follows on from the corrected code snipped in the example. Perhaps it will be done automatically? I'm not too familiar with the repo/release setup, sorry!

The image in question is https://www.tensorflow.org/static/probability/examples/Gaussian_Copula_files/output_JbLhzyye9c49_0.png

shown on the Copulas Primer page at https://www.tensorflow.org/probability/examples/Gaussian_Copula

With the changes in this PR, the image should look quite different, something more like this:

Jul 25 '22 20:07 gmjw

I think you'd need to re-run the colab and then download and add the altered colab file into your pull request.

Sep 20 '22 17:09 SiegeLordEx