Gazy Mahomar

Results 7 comments of Gazy Mahomar

Adding ability to run npm ci by default

@phracek Are there any updates on this feature?

[poll] is it a good idea?: rename 'partial mock' to 'merged' or 'blended' mock

Hey, I appreciate you asking for my input. So far, I agree with @jakebailey. Borrowing the existing terminology in this thread, "strict" is what I have come to expect the...

[poll] is it a good idea?: rename 'partial mock' to 'merged' or 'blended' mock

> I did not like gmahomarf's suggestion a choice be made they agree with or "fork or find another project" or implied concerns of release mismanagement. > All I meant...

fix: destroyed async/await handler

I'm not sure how this fixes #1935. The issue there is that one is no longer allowed to have `async` handlers which also call `next`, due to handler arity checks.

New async/await handler support breaks `next(false)` functionality in current async handlers

> Calling `next` **is not allowed** when using `async` functions. That said, I agree Restify must provide _**a way to stop chain processing**_, similarly to `next(false);`. Yes, I'm well aware...

New async/await handler support breaks `next(false)` functionality in current async handlers

> In an async handler you have to throw an error instead of calling `next(false)` (@ghermeto, @gmahomarf). And for `response.redirect(...)` see #1916. No, because I don't want to throw an...

New async/await handler support breaks `next(false)` functionality in current async handlers

I don't want any errors when all I'm trying to do is stop the chain. I also don't like using next in async handlers, but there's currently no other way...