node-restify icon indicating copy to clipboard operation
node-restify copied to clipboard

fix: destroyed async/await handler

Open misyuari opened this issue 3 years ago • 3 comments

Pre-Submission Checklist

  • [x] Opened an issue discussing these changes before opening the PR
  • [x] Ran the linter and tests via make prepush
  • [x] Included comprehensive and convincing tests for changes

Issues

Closes:

  • Issue #1941

Changes

Fix unstopped chain-handler when response already destroyed.

misyuari avatar Dec 16 '22 13:12 misyuari

I'm not sure how this fixes #1935. The issue there is that one is no longer allowed to have async handlers which also call next, due to handler arity checks.

gmahomarf avatar Feb 05 '23 12:02 gmahomarf

I'm not sure how this fixes #1935. The issue there is that one is no longer allowed to have async handlers which also call next, due to handler arity checks.

oh that was my fault, looks like it's a different issue, I've created a new issue

misyuari avatar Feb 05 '23 13:02 misyuari

can you add tests?

done, test added

misyuari avatar Feb 16 '23 10:02 misyuari