Guillaume Lambert

Results 17 comments of Guillaume Lambert

Would this also allow to have a static website always on the same URL for the latest `master`?

@bahmutov here's the public repo I've created serving as an example: https://github.com/glambert/nextjs-cypress-setup

@paleite not anymore because I used that repo for internal usage, but if you have specific questions I can help out!

That'll do it for now, thanks a lot! I will keep myself to subscribed to this if you find a way to make this an option πŸ˜‰

2 themes is fine imo, `Atom One Light` is also OK.

You can see the upgrade guide here: https://github.com/JedWatson/react-select/issues/3585

Partially closed by #7, correct?

> `flame/stories/styles/stories.scss` still uses a bunch of Sass Yup, "partially" is the keyword πŸ˜„This still needs to be done, wanna pick up @alexismo? πŸ˜‰

I would also add in `internal` before `parent` for path aliased imports. From the `eslint-plugin-import` [docs](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md#importorder-enforce-a-convention-in-module-import-order): >3. "internal" modules >// (if you have configured your path or webpack to handle...

I was also thinking about using [newlines-between](https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/order.md#newlines-between-ignorealwaysalways-and-inside-groupsnever) option set as `always` for readability, what do you think?