flame
flame copied to clipboard
eslint-ordering configuration updated
Description
we should be using ["builtin", "external", "internal", "parent", "sibling", "index"] instead of the airbnb defaults as the current setup is a bit too loose in how to order imports.
We will need to:
- add
'import/order': ['error', { groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'] }]to the.eslintrc.jsrules object - fix any potential errors that will arise (just run
yarn lint --fix)
I would also add in internal before parent for path aliased imports. From the eslint-plugin-import docs:
- "internal" modules // (if you have configured your path or webpack to handle your internal paths differently)
Updated issue description accordingly.
I was also thinking about using newlines-between option set as always for readability, what do you think?