Gino Miceli

feat(query): warning for invalid query config parameters

1

Reposting https://github.com/prescottprue/react-redux-firebase/issues/537 in the correct repo. This turned out to be due to a call to firestore.update() where the path was referring to a collection rather than a doc. This...

Cloud builds failing due to duplicate BuildConfig classes

2

@shobhitagarwal1612 Is this related to the refactor of the shared test classes? Latest log: https://pantheon.corp.google.com/cloud-build/builds/dfa0e6be-c7d1-4e9a-a30b-0c0ac2495446;step=3?project=ground-android-gcb

Towards #1175. @scolsen PTAL?

[Code health] Harmonize representation of points, polygons, and GeoJSON

9

Shapes are represented in remote db in features as `point` (GeoPoint), `geoJson` (string) and `geometry` (map). There's also some confusion in the implementation about geometries vs LOIs. This design wasn't...

[Location lock] Crosshairs lags behind blue dot on map when walking

2

To repro, load https://www.gpsvisualizer.com/examples/google_gpx.html in emulator and play back at 1x speed, enabling location lock. 

[Map] Enlarge marker of selected LOI

5

It's currently difficult to understand which marker is selected. Suggestion: 

[Code health] Abstract Maps API LatLng* with custom model class

1

We shouldn't expose Maps API to Ground business logic, both to enforce SoC/Clean arch, and to allow us to add other maps providers in the future.

[Offline base maps] Show available and est. required storage for offline areas

3

This will help users understand how much storage downloaded imagery will require, and how much space is left. For ex:

Currently I see only "Brazil" or "Peru" even when selecting some areas a high zoom levels. To solve this we can reverse geocode near the four corners of the viewport,...