George O. Lorch III

https://jenkins.percona.com/view/TokuDB/job/PerconaFT-param/122/ https://jenkins.percona.com/view/PS%205.6/job/percona-server-5.6-param/2147/ https://jenkins.percona.com/view/5.7/job/mysql-5.7-param/1766/ https://jenkins.percona.com/view/5.7/job/mysql-5.7-param/1771/ The second 5.7 jenkins is a matrix reload on 4 failures due to some odd git state weirdness, they failed to clone/checkout my branch.

OK, I reworked it a bit more and factored out the write error handing as well as it wasn't really doing what the function names might indicate. Here is a...

We should always try to use distro packages for 3rd party libs unless some truly horrible error or _significant_ performance issue is present. Embedding 3rd party libs/source into a project...

clang-format issues https://app.circleci.com/pipelines/github/percona/percona-server/4568/workflows/64f60ed5-aa6d-4bda-a1c8-9a1f285a8190/jobs/4550

First off, thank you for your contribution! I do have a concern of changing user interface, even though the behavior would be controlled by log_timestamp, I believe it is more...

Hello again @fmbiete, Thank you very much for the changes. Typically we require 1 commit per PR (with exceptions). So you would need to squash these two together (or we...

Excellent @fmbiete, thank you for this. I will run this through our internal CI/CD system and get a further review done. We will need to create JIRA issues for this...

Hello again @fmbiete. I missed the part where you added usec to all timestamps. this is also not going to be allowed by default as it would/could break existing parsers...

Great catch, preliminary review looks good. I'll look at it again tomorrow and see if a test case can be created for it.

I would prefer a PerconaFT type ctest rather than an mtr case, I can try to create one for you. We don't use github issues as they are too 'simple'...