PerconaFT icon indicating copy to clipboard operation
PerconaFT copied to clipboard

DB-883 tokudb broken after 'create database log002015'

Open bohutang opened this issue 10 years ago • 4 comments

[summary] In is_a_logfile_any_version, the uninitialized variable is terrible when we complied with -O3 flag, if we have a directory named 'log02015', 'n' is undefined value after sscanf

Copyright (c) 2015, BohuTANG All rights reserved.

Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

  1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.
  2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

bohutang avatar Sep 18 '15 02:09 bohutang

Great catch, preliminary review looks good. I'll look at it again tomorrow and see if a test case can be created for it.

george-lorch avatar Sep 18 '15 03:09 george-lorch

test case is here: https://github.com/percona/tokudb-engine/pull/294/files

It's better to use github issues instead of atlassian. Everything is tracked via github :dancer:

bohutang avatar Sep 18 '15 03:09 bohutang

I would prefer a PerconaFT type ctest rather than an mtr case, I can try to create one for you.

We don't use github issues as they are too 'simple' and don't match our workflow. We will be moving bug tracking over to launchpad within the percona-server project as the various repos get merged.

george-lorch avatar Sep 18 '15 15:09 george-lorch

add FT type test

bohutang avatar Sep 20 '15 11:09 bohutang