Lukas Gächter

Results 150 comments of Lukas Gächter

@joepagan This probably fixes the issue with W3C validator. But in a quick test, only Chrome and Firefox downloaded the correct sizes for images. Other browsers like IE and Safari...

I’m seeing the same result as @oligafner on https://plyr.io. MacBook Pro (13-inch, 2019) Browser: Safari Version: 14.1.1 (15611.2.7.1.6) Operating System: macOS Catalina Version: 10.15.7 ![grafik](https://user-images.githubusercontent.com/2084481/124719391-5f34e800-df07-11eb-9860-d2e8a6a2cc93.png)

I ran into the same error and figured out that the `twig/cache-extension` package is the reason why you end up with a bunch of gibberish namespaces on every line of...

I also ran into this problem. It can be observed in the following pen: https://codepen.io/gchtr/pen/KKgXRPP, where I prepared some anchor links that result in different scroll positions depending on which...

I had the same error both with svgo-gui and gulp-svgo and tried exporting it from **Adobe Illustrator** in a different format. With a little trial and error I found out...

This issue also causes problems with [MultilingualPress](https://multilingualpress.org/). I’d appreciate it very much if this could be addressed soon.

I think it’s the following to errors: ``` There were 2 errors: 1) TestTimberImage::testImageSizes Undefined property: Timber\ImageDimensions::$image /home/runner/work/timber/timber/src/ImageDimensions.php:116 /home/runner/work/timber/timber/src/ImageDimensions.php:54 /home/runner/work/timber/timber/src/Image.php:238 /home/runner/work/timber/timber/tests/test-timber-image.php:197 phpvfscomposer:///home/runner/work/timber/timber/vendor/phpunit/phpunit/phpunit:97 2) TestTimberImage::testSVGDimensions Undefined property: Timber\ImageDimensions::$image /home/runner/work/timber/timber/src/ImageDimensions.php:116 /home/runner/work/timber/timber/src/ImageDimensions.php:[54](https://github.com/timber/timber/actions/runs/3048958254/jobs/4933686252#step:17:55) /home/runner/work/timber/timber/src/Image.php:238...

@xavivars I’ll have a look at the tests.

@szepeviktor Well, they apparently were made by someone who knows his stuff 😉💪

@szepeviktor Thanks for your insights! > I contacted Elliot and he was happy about docblock fixes but refused them. I see 🙃. > Currently invalid docblocks are _dumbfixed_ by string...