Lukas Gächter

Results 150 comments of Lukas Gächter

Thanks for digging deep into this! Hm... is the problem actually with `Timber\Timber::__construct()` or `Timber\Twig::__construct()`? In your pull request, I see that you’re creating an instance of `Timber\Twig`, which calls...

@drzraf Thanks for taking this up again. Yes, we should change that. I’ve long changed to not calling hooks in constructors in my own projects. It’s something I stumble over...

We just released a first beta for Timber 2.0: [2.0.0-beta.1 (release)](https://github.com/timber/timber/releases/tag/2.0.0-beta.1). Unfortunately, we have no final release date yet and we don’t want to commit to one, because we all...

@szepeviktor Yep, working through the issues that PHPStan reports up to a certain level is also on our list. 👍

My opinion on how to define how images are processed with arguments and an overview of what needs to considered when touching image functions can be found here: https://github.com/timber/timber/issues/857#issuecomment-364782702. Recently...

@palmiak I’d be happy if you could take this over! I have some big updates to the documentation I’m still working on. I think I wouldn’t change only the third...

I’m reopening this. I ran into the same issue and came up with a solution in #2376 that uses a combination of 2. and 3. from @haroldangenent’s suggestions. > I...

I like this! Clearer error messages always help. And it’s probably better for code hinting in the various IDEs. Can we define some rules/guidance, when we would apply it? -...

I think there wasn’t really a discussion prior to this. We might have all heard it, but for completeness, I’m adding the link here: [WordPress will probably update the minimum...

Timber 2.0 will require PHP 7.0. So it should be clear which type hints we can add.