Guillermo Bernárdez
Guillermo Bernárdez
Really nice and practical addition to TopoNetX! For sure point 1 can be easily solved by making use of the implemented normalizations (in fact, `compute_bunch_normalized_matrices` precisely does the desired transformation,...
Working on decoupling the readout from cell/combinatorial models, similarly to what was done for simplicial and hypergraph architectures (PRs #250 and #249, respectively).
Hey! Working on the tutorial checks I realized there was a bug in `Dist2CycleLayer` when defining the dimensions of the `self.fc_neigh`. I made `Dist2Cycle` work with multiple layers by changing...
Hi @grapentt ! Just marked your PR as ready for review--the submission seems to be completed. However, feel free to modify it further if you want to! Thank you!
Hi @amiiiza! Two quick comments: - Don't worry about the project coverage, it failing is not related to your PR (I am trying to fix it now). Sorry for the...
Hi @Loris697! Did you fill out [the required Google Form](https://docs.google.com/forms/d/e/1FAIpQLSfalC7mst38HrQFQjwIaj-ocOdk5Ni0M5X1dfH8pyTGHG32bg/viewform?usp=dialog) with the information of your PR? We don't find an entry assigned to your PR. Thank you!
Hi @dario-loi! After taking a quick look at the tests error (the shape mismatch), I'd recommend to ensure you have the latest changes from TopoBench `main` in your local branch....
Sorry for the delay in my response, @dario-loi ! No worries at all about the extra tests, for sure they won't penalize even if they were redundant. We will analyze...
Hi @grapentt! Feel free to modify `pyproject.toml` file to include any extra dependencies you might need for your submission. Good luck!
Hi @marindigen! It seems that the testing error can be easily fixed just by slightly renaming the newly introduced `test_io_utils.py` file. Good luck!