Walid Gara comments

Results 13 comments of


                                            Walid Gara

[FEATURE] Add linter to CI/CD pipeline

Related to #213

[FEATURE] Add linter to CI/CD pipeline

@jacobmontiel @smastelini I made a quick test and I found only these two style exceptions. Any thoughts?

[FEATURE] Add linter to CI/CD pipeline

@jacobmontiel I find 99 characters good as well, especially when I use a wide screen. I'll create an initial PR ASAP.

[FEATURE] Add linter to CI/CD pipeline

Using a 99-character rule will lead to many changes. I made a PR (#221) with an initial linting. I've been thinking of using 120 characters. What do you think?

[FEATURE] Add linter to CI/CD pipeline

Here are some statistics on the number of lines that exceed 99 character per module ``` # tests 3 neural_networks 16 data 1 transform 11 meta 2 utils 5 metrics...

[FEATURE] Add linter to CI/CD pipeline

Here is a summary of the number of lines that violates the rule [E501](https://www.flake8rules.com/rules/E501.html): | File | case of 79 characters | case of 99 characters | case of 120...

[FEATURE] Add linter to CI/CD pipeline

99 sounds good for me too. I'll continue the PR. Thanks @jacobmontiel, @smastelini

[FEATURE] Add linter to CI/CD pipeline

I noticed that linting the project in one shot is quite difficult since we have new PRs and my pace is quite slow. So, I decided to break the linting...

[FEATURE] Add linter to CI/CD pipeline

@smastelini Sorry for the late response. 1. I use Pycharm to lint the code (Code -> Reformat code). 2. I use [autopep8](https://pypi.org/project/autopep8/) to fix [W293](https://www.flake8rules.com/rules/W293.html). ```bash $ python3 -m autopep8...

PARQUET-1787: Fix parsing expected distinct numbers

@Fokko, @chenjunjiedada thanks for the review. Nice catch!