parquet-java icon indicating copy to clipboard operation
parquet-java copied to clipboard

PARQUET-1787: Fix parsing expected distinct numbers

Open garawalid opened this issue 6 years ago • 5 comments

Make sure you have checked all steps below.

Jira

  • [x] My PR addresses the following Parquet Jira issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
    • https://issues.apache.org/jira/browse/PARQUET-XXX
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Tests

  • [x] My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

  • [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • [ ] In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain Javadoc that explain what it does

garawalid avatar Feb 05 '20 23:02 garawalid

@Fokko, @chenjunjiedada thanks for the review. Nice catch!

garawalid avatar Feb 06 '20 23:02 garawalid

@garawalid thanks for the patch, it looks good to me except one small nit for code style.

chenjunjiedada avatar Feb 11 '20 12:02 chenjunjiedada

@garawalid , would you please update the pull request against the master?

chenjunjiedada avatar Feb 27 '20 00:02 chenjunjiedada

@chenjunjiedada I think it's better to wait for PARQUET-1805(#763) to be merged. I will rewrite the tests with the new configuration.
What do you think?

garawalid avatar Feb 27 '20 22:02 garawalid

@chenjunjiedada could you please review it again if you have some free time? Thanks.

garawalid avatar Apr 16 '20 14:04 garawalid