Greg Orlov comments

Results 42 comments of


                                            Greg Orlov

Non-ActiveRecord paginator support

@tiagopog, I would love some feedback on this.

Non-ActiveRecord paginator support

@tiagopog bump?

Non-ActiveRecord paginator support

@tiagopog have you had a chance to look at this at all?

FIX: Compact path array to support multiple shallow path belongs_to

Thanks for taking the time! can you please update the changelog?

Proposal to add coersion or proc types

Would you be open to opening up a PR with an idea of how that would work?

Proposal to add coersion or proc types

@senid231 what do you think about a `call`able type? Have you seen people use the types much?

Proposal to add coersion or proc types

@senid231 I guess my question is more: does this belong in the client gem or is this a higher level concern? This feels like parser logic rather than a cast/field...

Relax faraday dependency to allow 1.3.x

This looks reasonable. Can you take a look at the failing test and see if it's related to the change? Thanks!

Support for RSpec's `instance_double`

Is this still an issue, @delner? Would you be willing to work with us to PR it into the gem?

Adding a record to a has_many relationship should be able to POST

Oh. That's not great. I'll take a look. Thanks for bringing this up!