Faizaan Gagan

Results 10 comments of Faizaan Gagan

The fix isn't good ;). It currently breaks a core behavior which is exposed by the failed rspec test. Hence the draft status of the PR. I'm re-thinking about a...

Just wondering, when you initialize with an empty `songs` array, does `Amplitude.addSong` make any difference?

Thanks for taking this step @danpastori I was wondering, is it worth having two ways to initialize Amplitude. IMHO, if it was possible to make `Amplitude.init` call optional, that would...

@angusmcleod Here's a PR which cherrypicks the workflow updates to stable. - Discourse branch checked out `stable` - Plugin branch checkout out `stable` Also, we've uncovered another bug here. We...

@angusmcleod I'll do some more work on this today to build the same architecture for `Steps`.

@angusmcleod We're defining `buildSubscriptionContent` but calling `generateSubscriptionContent`

@angusmcleod Lets merge https://github.com/paviliondev/discourse-custom-wizard/pull/182 into main and this one and make sure the correct branch of discourse and the plugin is checked out and the workflow succeeds.

Faced the same issue with `execnb` when installing via conda since it installs `0.1.11` version. using `pip install` fixed it since it installed `0.1.14`.

```python def set_default_device(device): # to make sure we always return a torch.device object dev = torch.device(device) torch.set_default_device(dev) return dev def default_device(use=-1): "Return or set default device; `use_cuda`: -1 - CUDA/mps...

Also, confirmed that directly passing a value in the constructor correctly sets it in the `n_acc` class member: So its ok to pass the param directly or as `n_acc=64`