discourse-custom-wizard icon indicating copy to clipboard operation
discourse-custom-wizard copied to clipboard
verified publisher icon paviliondev

IMPROVE: improve how subscription type checks are handled

Open angusmcleod opened this issue 3 years ago • 4 comments

angusmcleod avatar Feb 14 '22 06:02 angusmcleod

This pull request introduces 1 alert when merging 7de00ca04073edd085b09efa7dfde4f18392d611 into 4605b23585aef3de0e8f2b81c2e3970e96dcfd92 - view on LGTM.com

new alerts:

  • 1 for Syntax error

lgtm-com[bot] avatar Feb 14 '22 06:02 lgtm-com[bot]

This pull request introduces 2 alerts when merging 5a347b656a827935438673c4abdf85ffbf6156de into 4605b23585aef3de0e8f2b81c2e3970e96dcfd92 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class
  • 1 for Invocation of non-function

lgtm-com[bot] avatar Feb 14 '22 06:02 lgtm-com[bot]

@angusmcleod We're defining buildSubscriptionContent but calling generateSubscriptionContent

fzngagan avatar Feb 14 '22 07:02 fzngagan

@angusmcleod Lets merge https://github.com/paviliondev/discourse-custom-wizard/pull/182 into main and this one and make sure the correct branch of discourse and the plugin is checked out and the workflow succeeds.

fzngagan avatar Feb 15 '22 19:02 fzngagan