Mark Junker

Results 214 comments of Mark Junker

1. The visibility changing from protected to public should happen automatically as long as you don't provide the primary constructor 2. `public` on an abstract class doesn't make sense, because...

It surely seems that development slowed down, but several PRs were merged/closed during this year and after a look at the remaining ones, it seems that the open PRs are...

I've already done this before with the [FluentMigrator project](https://github.com/fluentmigrator/fluentmigrator). I took over from the previous maintainer, created an ORG, moved the project, configured build servers, added a documentation project, made...

@ruslanmogilevskiy I highly respect the work that was done on this project. We'll see if s/o reponds here in January (after the holidays) and currently, there is no need to...

It seems that you're right. I'll look into it.

You've found a bug 👍 The line [`ILoggerFactory? loggerFactory`](https://github.com/FubarDevelopment/FtpServer/blob/f0922b580c3795856b3208a18a8be6765a5510e9/src/FubarDev.FtpServer.FileSystem.Unix/UnixFileSystemProvider.cs#L33) should read `ILoggerFactory? loggerFactory = null`. You can also add logging to your app (https://learn.microsoft.com/en-us/dotnet/api/microsoft.extensions.dependencyinjection.loggingservicecollectionextensions.addlogging?view=dotnet-plat-ext-7.0&viewFallbackFrom=net-6.0).

I'd wish that you'd keep it, but I can understand that you want to reduce the complexity of supporting old target frameworks. I'm currently stuck supporting an MFC application, which...

It was a deliberate decision to not remember the action as successful or failed when an exception other than `EntryPointNotFoundException` gets thrown. I can mark it as successful, but it...

Hi, thank you for your review. I made the two requested changes.

@cincuranet Hi, I made the requested changes. Are there any other open points with this PR?