NETProvider icon indicating copy to clipboard operation
NETProvider copied to clipboard

Use a ConcurrentDictionary to remember which calls did work

Open fubar-coder opened this issue 2 years ago • 3 comments

This is needed to avoid unnecessary EntryPointNotFoundException exceptions, as they massively slow down program execution - especially in development environments.

Fixes #1146

fubar-coder avatar Dec 04 '23 17:12 fubar-coder

It was a deliberate decision to not remember the action as successful or failed when an exception other than EntryPointNotFoundException gets thrown. I can mark it as successful, but it shouldn't change anything in terms of performance or reliability.

fubar-coder avatar Dec 04 '23 17:12 fubar-coder

Hi,

thank you for your review. I made the two requested changes.

fubar-coder avatar Mar 16 '24 23:03 fubar-coder

@cincuranet Hi, I made the requested changes. Are there any other open points with this PR?

fubar-coder avatar Jun 07 '24 14:06 fubar-coder

@cincuranet Hi, I made all requested style fixes. Thank you for your review.

fubar-coder avatar Jul 11 '24 14:07 fubar-coder