Yi Cheng

Results 77 comments of Yi Cheng

@Catch-Bull could you give the PR a better name and description? It's really confusing about what this one is doing just from the name.

hmmm, it seems the building of redis has some issues. I'm looking into this.

``` sentinel.c:34:10: fatal error: openssl/ssl.h: No such file or directory 34 | #include "openssl/ssl.h" | ^~~~~~~~~~~~~~~ ``` I need to change the bazel rule to build redis.

@scv119 ah,, I forget to include the unit test. I actually have one but forgot to add.

@simon-mo the services change is only for testing. Ray will not start redis for the user anymore. Ideally, the Redis change should be moved from the service.py to test.py. So:...

> didn't mean to approve, this PR needs documentation change as well @simon-mo right now, all the GCS Fault Tolerance features are only to support ray serve and the only...

@simon-mo updated to rediss://