Yi Cheng
Yi Cheng
@stephanie-wang could you take a look at this https://github.com/ray-project/ray/pull/31488 ``` if (arg_it->second.ShouldDelete(lineage_pinning_enabled_)) { // We only decremented the lineage ref count, so the argument value // should already be released....
@rkooo567 no we shouldn't turn on syncer by default. At the beginning, step by step is my plan. But I realized that even just with the unary syncer, it's already...
@rkooo567 yes, it is ready for review. I see some test failure there which seems not related.
> GRPC_ARG_MAX_CONCURRENT_STREAMS What if num of active streams exceed this?
> I am on the halfway review. Btw haven't we talked that we would generate a design doc before we go further or sth? I think we discussed after putting...
> I saw this is used within io service and outside @rkooo567 I agree with you on this. The root cause is the gRPC thread and io thread both will...
> LGTM. It'll be great if we have fault tolerance semantics documented somewhere. > > Also, the main concern is the threading model is confusing and hard to understand (though...
> resent because we will recreate the connection and it will be sent from there? Yes!
merge master to pr.
@rkooo567 I've tested them (CI https://buildkite.com/ray-project/oss-ci-build-pr/builds/10223#_). gcs ft related test failed, not sure the root cause. And also run many actor tests mannually and it look good with 250 nodes...