ray icon indicating copy to clipboard operation
ray copied to clipboard

[core][autoscaler][v2] Subscribers -ray stopper [2/x]

Open rickyyx opened this issue 2 years ago • 2 comments

Why are these changes needed?

This PR implements the subscriber for RAY_STOP_REQUESTED status transition.

Related issue number

Checks

  • [ ] I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • [ ] I've run scripts/format.sh to lint the changes in this PR.
  • [ ] I've included any doc changes needed for https://docs.ray.io/en/master/.
    • [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in doc/source/tune/api/ under the corresponding .rst file.
  • [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [ ] Unit tests
    • [ ] Release tests
    • [ ] This PR is not tested :(

rickyyx avatar Feb 10 '24 12:02 rickyyx

The rest lgtm.

fishbone avatar Feb 13 '24 02:02 fishbone

Need to handle drain vs ray stop properly here.

rickyyx avatar Feb 14 '24 07:02 rickyyx