Filip Radelic

I don't think it makes sense to enable portrait mode for an app that shows a fullscreen video that's always landscape and will show nothing more than big black bars...

I'd definitely let settings screen rotate to any orientation, not a problem since it's a separate activity, just not convinced about main video player activity needing portrait. I feel like...

> Personally I'd vote the water mark goes in the bottom left of the video frame, this way if in 4:3 and landscape you won't end up with the potential...

> @jlucidar I'd like to take a stab at adding this feature if you think that's cool. Have you heard of anyone else attempting this yet? I bought a VR...

> @jlucidar I have a branch ready to push to a PR, but when I try to push it says I don't have permission. Do you know what the problem...

As you said yourself, GPL isn't gonna stop anyone from using your code and ignoring the license. You don't have to look further than DJI itself to see this. Unless...

Ok a weird thing happened, I checked out the RTMP branch and suddenly could see the splash screen again instead of the white screen after checking out this branch again....

There is still a clear jump in alignment between splash screen and the status icon I can see, but now I am not sure if it's still a real thing...

@phillbaker that has been out for a long time, but it's not the same thing.

Has this not been resolved with v10.8.0 (2024-05-26)? Release notes mention it here: https://github.com/bwp91/homebridge-govee/releases/tag/v10.8.0 but I see the issue is still opened @rusnewman I'm looking into this light so wondering...