DigiView-Android icon indicating copy to clipboard operation
DigiView-Android copied to clipboard

Fixed splash screen

Open fmatt opened this issue 4 years ago • 4 comments

This PR adds a splash screen with a fixed aspect ratio for issue #62 To correctly align the splash image with the overlay, the alignment of the overlay icon and text was correctly centered. (The misalignment was noticeable on large screen devices like Pixel C.) The splash screen was tested with both light and dark theme on screen resolutions for following devices:

  • Pixel 2
  • Pixel 3a
  • Nexus 4
  • Pixel 4XL
  • Pixel C Screenshot_1622243390 Screenshot_1622243391

fmatt avatar May 28 '21 23:05 fmatt

looks ok. can we test this on some tablets maybe before merging ?

Yes, lets have some more tests, @fichek and i had inconclusive results with yesterdays changes (b7ce0c2). Does anyone notice a white background before the splash screen?

fmatt avatar May 31 '21 18:05 fmatt

looks ok. can we test this on some tablets maybe before merging ?

Yes, lets have some more tests, @fichek and i had inconclusive results with yesterdays changes (b7ce0c2). Does anyone notice a white background before the splash screen?

Doesn't happen on my phone (oneplus 5t)

jlucidar avatar Jun 01 '21 22:06 jlucidar

Ok a weird thing happened, I checked out the RTMP branch and suddenly could see the splash screen again instead of the white screen after checking out this branch again. Guess it's some weird caching issue (I did try uninstalling the app, restarting the phone etc.) and it's still present on the emulators I tried, but running the app on a new emulator shows the splash screen 🤷‍♂️

fichek avatar Jun 02 '21 15:06 fichek

There is still a clear jump in alignment between splash screen and the status icon I can see, but now I am not sure if it's still a real thing or just some caching issue? Is there a way to make sure this cache gets cleared?

fichek avatar Jun 02 '21 15:06 fichek