Florian Albrechtskirchinger comments

Results 136 comments of


                                            Florian Albrechtskirchinger

Update docset JSON_for_Modern_C++ to v3.11.1

> ``` > [NOTICE] Some pages loaded online resources, which might mean the docset doesn't work offline. > ``` That's probably the MathJax JavaScript. I know of one use in...

Update docset JSON_for_Modern_C++ to v3.11.1

A number of issues have been found in v3.11.1. There's going to be a v3.11.2 release soon.

Allow custom base class as node customization point

@nlohmann Please approve the workflow run.

Allow custom base class as node customization point

Looks like it just needs another review (which I can do either a little later today or over the weekend) and some attention from @nlohmann.

Allow custom base class as node customization point

Some notes for a follow-up PR: * Make specifying a base class easier/less verbose. * Warn users about potential conflicts with newer versions, i.e., base members should avoid generic names...

Split inline namespace and allow version namespace to be disabled

It just expresses the hierarchy between the truly (and always) ABI-breaking settings and library versions. I don't really know yet if that's useful, but I don't think it hurts either.

Split inline namespace and allow version namespace to be disabled

ci_test_single_header failing is expected until #3679 is merged.

Split inline namespace and allow version namespace to be disabled

Yes. Since 3.11.0. https://github.com/nlohmann/json/issues/3657#issuecomment-1207175931 (And the test has been added to this PR.)

Split inline namespace and allow version namespace to be disabled

I've added a first, rough version of `features/namespace.md`. Clearly needs more polish in the future. Looking forward to incorporating any suggestions you may have.

Split inline namespace and allow version namespace to be disabled

Here's how the `plantuml` diagram in `features/namespace.md` renders: ![namespace md_uml](https://user-images.githubusercontent.com/320854/183675958-83431917-f0be-406c-9f15-8587977a8e32.png)